Problem: fee collection not compatible with parallel execution #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -195,6 +197,10 @@ | |||
| ) | |||
| } | |||
|
|
|||
| func (am AppModule) EndBlock(ctx context.Context) error { | |||
| return am.keeper.CreditVirtualAccounts(ctx) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
yihuang
changed the title
Comment on lines
+188
to
+190
| for key := range okeys { | ||
| cms.MountStoreWithDB(okeys[key], storetypes.StoreTypeObject, nil) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning test
mmsqe
reviewed
Mar 28, 2024
yihuang
commented
Mar 28, 2024
mmsqe
approved these changes
Mar 28, 2024
Solution: - support an idea of virtual account in bank module, where the incoming coins are accumulated in a per-tx object store first, then accumulate and credit to the real account at end blocker. it's nesserary to support parallel tx execution, where we try not to access shared states. more efficient sum support SendCoinsFromModuleToAccountVirtual fix test fix test fix lint fix test fix test fix test fix test fix test fix mock keeper try fix lint try fix lint reuse code try fix linter Update x/bank/keeper/send.go Signed-off-by: yihuang <[email protected]> algin panic call fix error handling try fix lint nolintlint generate falst postiive
yihuang
merged commit 9ef65ec
into
crypto-org-chain:release/v0.50.x
43 of 45 checks passed
zsystm
pushed a commit
to b-harvest/cosmos-sdk
that referenced
this pull request
May 28, 2024
…cution (crypto-org-chain#237) Reason for Cherry-pick: - Migrate Block STM (Parallel Transaction Execution) - Avoid common conflict problem (fee collection happens for every tx) Notes for Cherry-pick: - Use transient store instead of object store introduced by Cronos Original Commit Message: * Problem: no efficient way to collect fee Solution: - support an idea of virtual account in bank module, where the incoming coins are accumulated in a per-tx object store first, then accumulate and credit to the real account at end blocker. it's nesserary to support parallel tx execution, where we try not to access shared states. more efficient sum support SendCoinsFromModuleToAccountVirtual fix test fix test * fix lint * fix test * fix test * fix test * fix test * fix test * fix mock keeper * try fix lint * try fix lint * reuse code * try fix linter * Update x/bank/keeper/send.go Signed-off-by: yihuang <[email protected]> * algin panic call * fix error handling * try fix lint * nolintlint generate falst postiive --------- Signed-off-by: yihuang <[email protected]> Cherry-picked-by: zsystm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
support an idea of virtual account in bank module, where the incoming coins are accumulated in a per-tx object store first, then accumulate and credit to the real account at end blocker.
it's nesserary to support parallel tx execution, where we try not to access shared states in tx execution.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...